-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added-types #225
base: truth-redefined-again
Are you sure you want to change the base?
added-types #225
Conversation
@pratham-srivastava-07 is attempting to deploy a commit to the kossiitkgp Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please revert changes that are not relevant to your PR?
please clarify where I have to revert the changes...would be helpful. |
I think you have misunderstood the issue. We are extremely sorry since we did not explain it properly. We were referring the Backend endpoint types defined here. We wanted to add types for the remaining endpoints. |
okay...so should I try this one more time properly? |
Sure! Sorry for the inconvenience. |
so just for confirmation changes only have to be done in types.ts? |
Yes. |
can we have a quick sync up on meet? @harshkhandeparkar |
What do you want to discuss? |
i am still having problems understanding what exactly needs to be done |
Are you familiar with the KWoC Backend API endpoints? We have a wrapper function in the frontend that makes an API request and returns the result, and it maps every endpoint to its return type. But some endpoint types are still not present in the frontend. Adding them was the issue. |
okay |
This is not a huge priority. We do keep adding types as the need arises. If you don't feel comfortable continuing with this, it is fine. Other issues are always open :) |
okay will try one more time...if thats okay |
Sure |
Added types to the frontend project.