Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alan] Adds sieve and fizzbuzz programs and 42 #35

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

purpl3F0x
Copy link
Contributor

Adds 3 programs and their accompanied test files to the alan collection:

  • Sieve of Eratosthenes
  • FizzBuzz
  • The answer to life

@kostis
Copy link
Owner

kostis commented Aug 29, 2024

Thanks for the PR. The answer program is a bit strange because it requires reading some integer but does not do anything with it. I can see that it may result in a (justifiable) warning by some compilers. I'd rather not have test programs that produce warnings.

I suggest you change it to either not take any input or do something with that input and e.g. produce 42.

@purpl3F0x
Copy link
Contributor Author

purpl3F0x commented Aug 29, 2024

Thanks for the PR. The answer program is a bit strange because it requires reading some integer but does not do anything with it. I can see that it may result in a (justifiable) warning by some compilers. I'd rather not have test programs that produce warnings.

I suggest you change it to either not take any input or do something with that input and e.g. produce 42.

I've made a typo when transferring the file, the program wasn't valid.
I amended the commit with a correct one, which hopefully makes more sense.

@kostis
Copy link
Owner

kostis commented Aug 29, 2024

Is better now - I'll merge it. Thanks again.

@kostis kostis merged commit 3f40e83 into kostis:master Aug 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants