[pull] master from godotengine:master #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Signals with typed arrays were generating EmitSignal methods with untyped array parameters.
The wslay library, somehow unintuitively, will call the frame recv end callback for control frames. This has the side effect that while receiving a long message (i.e. a multi-frame message), if a control frame (e.g. a ping or pong) is received it may seem that a FIN frame has been received, resulting in the current code truncating the message. To avoid this, this commit now ignores the frame recv end callback, and instead rely on the msg recv callback where we can check the opcode, and is guaranteed to be called only when the FIN frame is received for text and binary frames.
- Tweak property hint ranges for some networking settings to ensure the minimum values don't break the debugger entirely. - Ensure shader time rollover is set to at least 1, as 0 causes a division by zero to occur. All relevant project settings are now covered by a range hint.
When profiling Dome Keeper, I found that in physics_process a HashMap gets cleared a lot, which ends up calling the Variant destructor. Calling Variant::clear() dominates this operation. By not uselessly setting the Type to NIL on destruction we save about 50% of time. This is likely because if there is a simple type in the Variant that doesn't need destructing, but now we write when we should just drop the Variant altogether. Since the value of Variant::type should be unobservable after destruction this doesn't change any outward behavior.
Co-authored-by: Kasper Arnklit Frandsen <[email protected]>
When using `queue_free()` on GraphNodes, `p_from` can become `nullprt`. This PR adds a check to prevent crashes in these situations.
Don't set `Variant::Type` in destructor
Make transform elements BitField in RetargetModifier
Add `Color.from_rgba8` and deprecate Color8
astcenc: Misc improvements and optimizations
CI: Fix GHA bug by defining a single concurrency
Respect `PROPERTY_USAGE_NEVER_DUPLICATE` with Make Sub-Resources Unique
Fix lightmapper penumbra computation
…tion-in-okhsl ColorPicker: Fix cursor position in OKHSL wheel
…-focus-when-recreating-full-inspector- Fix dictionary editor steals focus when reloading script.
Style: Enforce `AllowShortFunctionsOnASingleLine`
Respect system user setting for (un)installing APK
Improve performance with many static/sleeping bodies when using Jolt Physics
Windows: Implement native menu close callback
Fix looking at with 180 degree arc
Fix nullptr crash with freed `GraphNode` in GraphEditArranger
Add NavigationLink debug direction indicator
Make NavMeshQueries use NavRegionIteration polygons directly
Revert "Stop reporting contacts for sleeping bodies when using Jolt Physics"
SCons: Don't update node count when cleaning
Change `VisualShaderNodeVec4Constant` type to vec4
Remove unused OS `_display_driver_id` member
[Web] Fix `DirAccess::unlink()` not updating the IDBFS
[.NET] Fix EmitSignal with typed array parameters
Fix icon UIDs in Project Manager
Re-create missing .uid files
ProjectManager: Update project list placeholder when project is created
…toff GLTF: Always read `alphaCutoff` property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )