Merge pull request storybookjs#30310 from storybookjs/jeppe/fix-flaky…

…-test-runner-tests Tests: Disable flaky test-runner tests
kp-forks · Jan 21, 2025 · f3276d5 · f3276d5
2 parents f3c87f1 + 8768418
commit f3276d5
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 3 deletions.
diff --git a/code/core/template/stories/args.stories.ts b/code/core/template/stories/args.stories.ts
@@ -92,5 +92,6 @@ export const Events = {
     await new Promise((resolve) => channel.once(STORY_ARGS_UPDATED, resolve));
     await within(canvasElement).findByText(/updated/);
   },
-  tags: ['!vitest'],
+  // this story can't be reliably tested because the args changes results in renderPhases disrupting test runs
+  tags: ['!vitest', '!test'],
 };
diff --git a/code/core/template/stories/decorators.stories.ts b/code/core/template/stories/decorators.stories.ts
@@ -67,5 +67,6 @@ export const Hooks = {
     });
     await new Promise((resolve) => channel.once(STORY_ARGS_UPDATED, resolve));
   },
-  tags: ['!vitest'],
+  // this story can't be reliably tested because the args changes results in renderPhases disrupting test runs
+  tags: ['!vitest', '!test'],
 };
diff --git a/code/core/template/stories/globals.stories.ts b/code/core/template/stories/globals.stories.ts
@@ -44,7 +44,8 @@ export const Events = {
     await channel.emit('updateGlobals', { globals: { foo: 'fooValue' } });
     await within(canvasElement).findByText('fooValue');
   },
-  tags: ['!vitest'],
+  // this story can't be reliably tested because the globals changes results in renderPhases disrupting test runs
+  tags: ['!vitest', '!test'],
 };
 
 export const Overrides1 = {

diff --git a/code/core/template/stories/rendering.stories.ts b/code/core/template/stories/rendering.stories.ts
@@ -105,4 +105,6 @@ export const ChangeArgs = {
     await within(canvasElement).findByText(/New Text/);
     await expect(button).toHaveFocus();
   },
+  // this story can't be reliably tested because the args changes results in renderPhases disrupting test runs
+  tags: ['!vitest', '!test'],
 };
diff --git a/...ers/vue3/template/stories_vue3-vite-default-ts/CustomRenderOptionsArgsFromData.stories.ts b/...ers/vue3/template/stories_vue3-vite-default-ts/CustomRenderOptionsArgsFromData.stories.ts
@@ -34,6 +34,8 @@ const meta = {
                   </div>`,
     });
   },
+  // this story can't be reliably tested because the (inherited) args changes results in renderPhases disrupting test runs
+  tags: ['!vitest', '!test'],
 } satisfies Meta<typeof Reactivity>;
 
 export default meta;