Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang: remove PROVIDES:append settings #1037

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

ChenQi1989
Copy link
Contributor

With these settings, we'll have multiple providers of llvm. This means that with pristine poky master + meta-clang master, we'll have some output like below:

NOTE: Multiple providers are available for llvm-native (llvm-native, clang-native)
Consider defining a PREFERRED_PROVIDER entry to match llvm-native

And when running 'bitbake world', we'll get error messages like below:

ERROR: Multiple .bb files are due to be built which each provide llvm-native:
virtual:native:/PATH/TO/poky/meta/recipes-devtools/llvm/llvm_19.1.4.bb
virtual:native:/PATH/TO/Yocto/poky/meta-clang/recipes-devtools/clang/clang_git.bb

As the README.md has already specified how to use this layer, let's remove such settings before sorting things out.


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

With these settings, we'll have multiple providers of llvm. This means
that with pristine poky master + meta-clang master, we'll have some
output like below:

  NOTE: Multiple providers are available for llvm-native (llvm-native, clang-native)
  Consider defining a PREFERRED_PROVIDER entry to match llvm-native

And when running 'bitbake world', we'll get error messages like below:

  ERROR: Multiple .bb files are due to be built which each provide llvm-native:
    virtual:native:/PATH/TO/poky/meta/recipes-devtools/llvm/llvm_19.1.4.bb
    virtual:native:/PATH/TO/Yocto/poky/meta-clang/recipes-devtools/clang/clang_git.bb

As the README.md has already specified how to use this layer, let's
remove such settings before sorting things out.

Signed-off-by: Chen Qi <[email protected]>
@ChenQi1989 ChenQi1989 requested a review from kraj as a code owner December 2, 2024 06:57
Copy link
Owner

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kraj kraj merged commit 147349b into kraj:master Dec 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants