Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake-native.bbclass: Add ubfs specific variable to ignore list #886

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

kraj
Copy link
Owner

@kraj kraj commented Nov 22, 2023

These variables show up as dependencies of native recipes otherwise can cause clang-native to rebuild without a reason just when defined by a machine using ubifs.


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

These variables show up as dependencies of native recipes otherwise
can cause clang-native to rebuild without a reason just when defined by
a machine using ubifs.

Signed-off-by: Khem Raj <[email protected]>
@kraj kraj merged commit 288f752 into kraj:master Nov 22, 2023
1 check passed
@shr-project
Copy link
Contributor

How these variables end in cmake signature? I don't see it here, does some BSP export them or something? I think then the BSP layer should be fixed.

@kraj
Copy link
Owner Author

kraj commented Nov 22, 2023

they dont, the real problem was from BSP exporting these symbols for no reason. I will send a revert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants