Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a mutex to read and delete keys to avoid concurrent map writes. #123

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Add a mutex to read and delete keys to avoid concurrent map writes. #123

merged 1 commit into from
Oct 26, 2023

Conversation

taik0
Copy link
Member

@taik0 taik0 commented Oct 23, 2023 •
edited
Loading

Fixes #122

@taik0 taik0 requested review from kpacha and dhontecillas October 23, 2023 10:24
dhontecillas
dhontecillas approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@dhontecillas dhontecillas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@kpacha kpacha merged commit eb56286 into master Oct 26, 2023
1 check passed
@kpacha kpacha deleted the cache_delete_key branch October 26, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhontecillas dhontecillas dhontecillas approved these changes

@kpacha kpacha kpacha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"fatal error: concurrent map writes" when trying to delete a key
3 participants
@taik0 @kpacha @dhontecillas