feat: support for scope list in JWT token for scope validation #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirm-in
force-pushed
the
master
branch
6 times, most recently
from
23a7f3c to
ed10abe
Compare
before this commit, when passing the token, the scopes should be separated by spaces, e.g: "my_scopes": "scope1 scope2", the commit enables suporting a list of scopes when passing the token, e.g: "my_scopes": ["scope1", "scope2"]. Original implementation by Xiaofei Du. Co-authored-by: Xiaofei Du <[email protected]> Co-authored-by: Pirmin Schneider <[email protected]>
Co-authored-by: Xiaofei Du <[email protected]>
|
Thank you @pirm-in ! We will review it and get back to you |
|
Hi there, just wanted to know if there might be any news to this? |
kpacha
approved these changes
Jan 24, 2024
|
@pirm-in thanks for the contribution! We'll make a little change in the |
alombarte
added a commit
to krakend/krakend-schema
that referenced
this pull request
Jan 24, 2024
alombarte
added a commit
to krakend/krakend-schema
that referenced
this pull request
Mar 11, 2024
* Prepare v2.6 release * Add new JWT validator options PRs: krakend/krakend-jose#129 and krakend/krakend-jose#128 * OpenTelemetry * OpenTelemetry * OpenTelemetry * Correct usage of example_schema in OpenAPI * Add report_headers to OTEL * Add new properties of OpenAPI * Add new properties of OpenAPI * Default values for skip_pahts in OTEL * Pre-release schema v2.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is re-opening an older PR by xiaofei-du
Why
When validating the JWT token, the original krakend-jose only supports space-delimited scopes, e.g:
This PR makes krakend-jose also support scope list in JWT token , e.g:
This makes krakend compatible with third party providers using this format.