Skip to content

Commit

Permalink
Use php as default serializer (again)
Browse files Browse the repository at this point in the history 
As reported in #350, the "default" serializer still/again has issues,
so switch back to using "php" as default for the time being.
  • Loading branch information
@nikic
nikic committed Nov 26, 2018
1 parent 75cecf6 commit cd69041
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion php_apc.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ STD_PHP_INI_BOOLEAN("apc.slam_defense", "0", PHP_INI_SYSTEM, OnUpdateBool,
STD_PHP_INI_ENTRY("apc.preload_path", (char*)NULL, PHP_INI_SYSTEM, OnUpdateString, preload_path, zend_apcu_globals, apcu_globals)
STD_PHP_INI_BOOLEAN("apc.coredump_unmap", "0", PHP_INI_SYSTEM, OnUpdateBool, coredump_unmap, zend_apcu_globals, apcu_globals)
STD_PHP_INI_BOOLEAN("apc.use_request_time", "1", PHP_INI_ALL, OnUpdateBool, use_request_time, zend_apcu_globals, apcu_globals)
STD_PHP_INI_ENTRY("apc.serializer", "default", PHP_INI_SYSTEM, OnUpdateStringUnempty, serializer_name, zend_apcu_globals, apcu_globals)
STD_PHP_INI_ENTRY("apc.serializer", "php", PHP_INI_SYSTEM, OnUpdateStringUnempty, serializer_name, zend_apcu_globals, apcu_globals)
PHP_INI_END()

/* }}} */
Expand Down

2 comments on commit cd69041

@zbenc
Copy link

@zbenc zbenc commented on cd69041 Dec 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikic Any idea what the issue is? It must arise somewhere in apc_persist_calc_ht() or apc_persist_copy_ht(), given that those are the only instances where the default serializer bypasses serialization (!ctxt->serializer).

@nikic
Copy link
Collaborator Author

@nikic nikic commented on cd69041 Dec 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed some issues in fa5f327, but beyond that I don't know. I'd need a reproduce case to figure out what the issue here might be.

Please sign in to comment.