Reduce memory per shm string by 8 bytes #465
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #323
This slightly helps performance of
apc.serializer=default
when there are lots of small strings to unpersist. (and reduces size of serialized data (and cache entry keys) by 8 bytes with other serializers (16 bytes per entry))With APCu's current design and eviction always being a possibility, strings must always be copied.
(zval flags could be used to check the type if that stopped being the case)
For example, fetching a large array mapping small strings to small strings (CPU running at 2.5GHz):
Benchmark source code (click to expand)