Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update s2 to use published version from npm #1422

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Conversation

gr0uch
Copy link
Contributor

@gr0uch gr0uch commented Oct 16, 2023

Since I got pinged here, I might as well update it.

@krausest
Copy link
Owner

Sorry, it's no longer keyed:

npm run isKeyed -- --headless true keyed/s2
Keyed test for create rows failed. Expected that 1000 TRs should be removed and added, but there were 0 added TRs and 0 were removed
s2-v1.0.17-keyed is non-keyed for 'run benchmark' and keyed for 'remove row benchmark' and keyed for 'swap rows benchmark' . It'll appear as non-keyed in the results
ERROR: Framework s2-v1.0.17-keyed is not correctly categorized

We can either move it to non-keyed or you'd have to fix the behavior.

@gr0uch
Copy link
Contributor Author

gr0uch commented Oct 19, 2023

huh... I'll fix that

@gr0uch
Copy link
Contributor Author

gr0uch commented Oct 19, 2023

the keyed test has been satisfied, i did have to add a line in the implementation to force the keyed behavior.

@krausest krausest merged commit 7bf1f46 into krausest:master Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants