Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sonnet to 0.0.33 #1758

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Bump sonnet to 0.0.33 #1758

merged 1 commit into from
Nov 1, 2024

Conversation

13770129
Copy link
Contributor

@13770129 13770129 commented Oct 26, 2024

Bumped sonnet to 0.0.33 🐈‍⬛

@13770129 13770129 changed the title Bump sonnet to 0.0.33 Bump sonnet to 0.0.33 Oct 26, 2024
@krausest
Copy link
Owner

krausest commented Nov 1, 2024

My test tells me that the non-keyed version is actually keyed. Can we just remove the non-keyed table? I mean it's definitely not a shame to be proud of being only keyed 😄
@htmujahid Would that be OK for you?

@htmujahid
Copy link
Contributor

Yes sure

@krausest krausest merged commit ca3b0a0 into krausest:master Nov 1, 2024
@krausest
Copy link
Owner

krausest commented Nov 1, 2024

Thanks. Here's a comparison:
Screenshot 2024-11-01 at 21 42 25
Take it with a grain of salt since it's an incremental run and those tend to be slower than full runs, though vanillajs was this time within 0.1 to the full run.
Sonnet is 0.3 slower than in the full run and now on the level of vanillajs. We'll see in the next full run whether it sill outperforms vanillajs and vanillajs-3.

@syduki
Copy link
Contributor

syduki commented Nov 1, 2024

We'll see in the next full run whether it sill outperforms vanillajs and vanillajs-3.

That is really a paradoxical situation, as the Sonnet benchmark is just vanillajs-3 wrapped in a class component, the only thing Sonnet does there is the initial layout, i.e. the buttons and table body.

@krausest
Copy link
Owner

krausest commented Nov 2, 2024

I ran the incremental run again, please see #1721 (comment) for details.
Good news is that sonnet and vanillajs-3 performed close to each other (within 0.1 range), the bad news is they were both slower than in the full run.

@13770129 13770129 deleted the sonnet branch November 4, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants