Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix security issues for snyk result #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jisoolee
Copy link

ref #31
ref #32

@jisoolee
Copy link
Author

@kirk7880 @krg7880
Could you take a look at my PR? Thank you for your time.

This will fix a number of snyk result

Current snyk result

High sev: 7
Medium sev: 8

JISOOs-MacBook-Pro:json-schema-generator [email protected]$ snyk test

Testing /Users/[email protected]/develop/json-schema-generator...

Tested 74 dependencies for known issues, found 15 issues, 19 vulnerable paths.


Issues to fix by upgrading:

  Upgrade [email protected] to [email protected] to fix
  ✗ Prototype Pollution [Medium Severity][https://snyk.io/vuln/SNYK-JS-MINIMIST-559764] in [email protected]
    introduced by [email protected] > [email protected] and 1 other path(s)

  Upgrade [email protected] to [email protected] to fix
  ✗ Prototype Pollution [High Severity][https://snyk.io/vuln/SNYK-JS-AJV-584908] in [email protected]
    introduced by [email protected] > [email protected] > [email protected]


Patchable issues:

  Patch available for [email protected]
  ✗ Prototype Pollution [High Severity][https://snyk.io/vuln/npm:extend:20180424] in [email protected]
    introduced by [email protected] > [email protected]

  Patch available for [email protected]
  ✗ Prototype Pollution [Medium Severity][https://snyk.io/vuln/npm:hoek:20180212] in [email protected]
    introduced by [email protected] > [email protected] > [email protected] and 3 other path(s)

  Patch available for [email protected]
  ✗ Prototype Pollution [Medium Severity][https://snyk.io/vuln/npm:lodash:20180130] in [email protected]
    introduced by [email protected] > [email protected] > [email protected]

  Patch available for [email protected]
  ✗ Uninitialized Memory Exposure [Medium Severity][https://snyk.io/vuln/npm:stringstream:20180511] in [email protected]
    introduced by [email protected] > [email protected]


Issues with no direct upgrade or patch:
  ✗ Prototype Pollution [High Severity][https://snyk.io/vuln/SNYK-JS-LODASH-450202] in [email protected]
    introduced by [email protected] > [email protected] > [email protected]
  This issue was fixed in versions: 4.17.12
  ✗ Prototype Pollution [Medium Severity][https://snyk.io/vuln/SNYK-JS-LODASH-567746] in [email protected]
    introduced by [email protected] > [email protected] > [email protected]
  This issue was fixed in versions: 4.17.16
  ✗ Prototype Pollution [High Severity][https://snyk.io/vuln/SNYK-JS-LODASH-590103] in [email protected]
    introduced by [email protected] > [email protected] > [email protected]
  This issue was fixed in versions: 4.17.20
  ✗ Prototype Pollution [High Severity][https://snyk.io/vuln/SNYK-JS-LODASH-608086] in [email protected]
    introduced by [email protected] > [email protected] > [email protected]
  This issue was fixed in versions: 4.17.17
  ✗ Prototype Pollution [High Severity][https://snyk.io/vuln/SNYK-JS-LODASH-73638] in [email protected]
    introduced by [email protected] > [email protected] > [email protected]
  This issue was fixed in versions: 4.17.11
  ✗ Regular Expression Denial of Service (ReDoS) [Medium Severity][https://snyk.io/vuln/SNYK-JS-LODASH-73639] in [email protected]
    introduced by [email protected] > [email protected] > [email protected]
  This issue was fixed in versions: 4.17.11
  ✗ Regular Expression Denial of Service (ReDoS) [Medium Severity][https://snyk.io/vuln/SNYK-JS-MARKDOWNIT-459438] in [email protected]
    introduced by [email protected] > [email protected]
  This issue was fixed in versions: 10.0.0
  ✗ Insecure Randomness [Medium Severity][https://snyk.io/vuln/npm:cryptiles:20180710] in [email protected]
    introduced by [email protected] > [email protected] > [email protected]
  This issue was fixed in versions: 3.1.3, 4.1.2
  ✗ Regular Expression Denial of Service (ReDoS) [High Severity][https://snyk.io/vuln/npm:sshpk:20180409] in [email protected]
    introduced by [email protected] > [email protected] > [email protected]
  This issue was fixed in versions: 1.14.1



Organization:      jisoolee
Package manager:   npm
Target file:       package.json
Project name:      json-schema-generator
Open source:       no
Project path:      /Users/[email protected]/develop/json-schema-generator
Licenses:          enabled

Run `snyk wizard` to address these issues.

After my PR snyk result

Medium sev: 1

JISOOs-MacBook-Pro:json-schema-generator [email protected]$ snyk test

Testing /Users/[email protected]/develop/json-schema-generator...

Tested 55 dependencies for known issues, found 1 issue, 1 vulnerable path.


Issues with no direct upgrade or patch:
  ✗ Prototype Pollution [Medium Severity][https://snyk.io/vuln/SNYK-JS-MINIMIST-559764] in [email protected]
    introduced by [email protected] > [email protected]
  This issue was fixed in versions: 0.2.1, 1.2.3



Organization:      jisoolee
Package manager:   npm
Target file:       package-lock.json
Project name:      json-schema-generator
Open source:       no
Project path:      /Users/[email protected]/develop/json-schema-generator
Licenses:          enabled

Run `snyk wizard` to address these issues.

Thank you in advance.

@jisoolee
Copy link
Author

And could you release a new version after this is merged? Thank you in advance 🙇

@jisoolee
Copy link
Author

@kirk7880 @krg7880 Is there any news for this? Thank you for your time.

@jisoolee
Copy link
Author

@kirk7880 @krg7880 Could you please take a look at this PR?

@jisoolee
Copy link
Author

@kirk7880 @krg7880 Any news for this?

@jisoolee
Copy link
Author

I guess I have to update some dependencies for this..

@jisoolee
Copy link
Author

@kirk7880 @krg7880 Could you take a look at this? This PR will resolve many snyk issues.

@jisoolee
Copy link
Author

Hello @kirk7880 @krg7880 , is there any updates?

@jisoolee
Copy link
Author

Hi @kirk7880 @krg7880 , could you take a look at this PR?

@jisoolee
Copy link
Author

jisoolee commented Feb 8, 2021

Hi @kirk7880 @krg7880 , could you please update this? There are High Severity issues which could be fixed by this update.

@jisoolee
Copy link
Author

Hello, @kirk7880 @krg7880 . Could you take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant