Improve XIO ROM sample #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(where they should be)
function renames Comment fixes
Rename extra functions within sys.c
Fix build.
Comment out previous commit.
Trying different commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves buildability, function names, ROM text and source comments (and formatting) for the XIO sample. Given that it is based on #17 , I would expect that to be merged before releasing this one (so it can be squashed correctly)
Related Issue
There is none.
Motivation and Context
The sample was previously un-buildable for most users, and the source was hard to read. I have improved the source as far as possible without renaming files (that will come in a later PR)
Further improvements for later would include making an ED64 lib and renaming source files, but it is best this is merged first.
How Has This Been Tested?
Loading the built ROM onto real hardware containing a V3 cart with V3.05 OS
Screenshots (if appropriate):