Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts/prepare-web): better error handling #1403

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pm-McFly
Copy link

  • validates that package exists before rm
  • cleans OLM_VERSION content
    • no more double quotes
    • no more version modifiers
  • no more directory jumping

Pull Request has been tested on:

  • Android
  • iOS
  • Browser (Chromium based)
  • Browser (Firefox based)
  • Browser (WebKit based)
  • Desktop Linux
  • Desktop Windows
  • Desktop macOS

	- validates that package exists before `rm`
	- cleans OLM_VERSION content
		- no more double quotes
		- no more version modifiers
	- no more directory jumping
@pm-McFly pm-McFly requested a review from krille-chan as a code owner October 10, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant