fix: inefficient ui flow of scan qr #1461
Open
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Dhruv80576 thanks for your contribution. It looks like you have implemented a deprecated widget: info • 'WillPopScope' is deprecated and shouldn't be used. Use PopScope instead. This feature was deprecated after v3.12.0-1.0.pre • lib/pages/new_private_chat/new_private_chat.dart:86:23 • deprecated_member_use |
|
Ohh i will update it |
|
@krille-chan |
krille-chan
requested changes
Nov 8, 2024
|
@krille-chan |
krille-chan
approved these changes
Nov 18, 2024
|
@Dhruv80576 Can you please squash your commits to one and sign it? Otherwise this cannot be merged |
|
@Dhruv80576 the Pull Request still has six commits. Can you squash then please to one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1453
UI flow for handling Scanqr popup has been handled and for that i used willPopscope ,when back is pressed popup will be closed.
Pull Request has been tested on: