Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Join public rooms #741

Merged
merged 1 commit into from
Dec 23, 2023
Merged

fix: Join public rooms #741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions lib/widgets/public_room_bottom_sheet.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,8 @@ class PublicRoomBottomSheet extends StatelessWidget {
}

void _joinRoom(BuildContext context) async {
final client = Matrix.of(context).client;
final client = Matrix.of(outerContext).client;
final chunk = this.chunk;
final navigator = Navigator.of(context);
final result = await showFutureLoadingDialog<String>(
context: context,
future: () async {
Expand All @@ -50,10 +49,10 @@ class PublicRoomBottomSheet extends StatelessWidget {
},
);
if (result.error == null) {
navigator.pop();
Navigator.of(context).pop();
// don't open the room if the joined room is a space
if (!client.getRoomById(result.result!)!.isSpace) {
context.go('/rooms/${result.result!}');
outerContext.go('/rooms/${result.result!}');
}
return;
}
Expand Down
Loading