Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed to using sphinx.ext.napoleon not sphinxcontrib.napoleon #288

Merged
merged 5 commits into from
Sep 4, 2023

Conversation

ChristopherMancuso
Copy link
Contributor

I tried to build the docs and it failed. This change worked and I got the info from sphinx-doc/sphinx#10378

@ChristopherMancuso
Copy link
Contributor Author

@RemyLau I thought I was making two pull requests, one for fixing the error in make html and the other for adding reticulate to the docs. But they appear to be just one pull request :(

Copy link
Contributor

@RemyLau RemyLau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ChristopherMancuso, thanks for your PR! I made some minor fixes to the doc configs required by recent updates to rtds. Otherwise it LGTM!

@RemyLau RemyLau merged commit 1b3aec4 into main Sep 4, 2023
8 checks passed
@RemyLau RemyLau deleted the reticulate branch September 4, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants