fix(notification): swap notifications info colours #289
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background
recently I fallback my colorscheme into the default colorscheme and decided to not use any syntax highlighting (but this shouldn't be the case) because I think the
hl
tag only respects from colorscheme rather than syntax, but what I found interesting is in thesetup_colors()
function in which we add a default color for the notification.in my case the bg and fg were overlapped and the notification only shows full black, and after swapping the
hl
forNotificationInfo
it works with displaying theguifg
(because in the default colorscheme, i think onlyguibg
are declared).here are some comparison with different "default" colorscheme...
before the swap
after the swap
steps to reproduce
guibg
hl set