Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notification): swap notifications info colours #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

padulkemid
Copy link

background

recently I fallback my colorscheme into the default colorscheme and decided to not use any syntax highlighting (but this shouldn't be the case) because I think the hl tag only respects from colorscheme rather than syntax, but what I found interesting is in the setup_colors() function in which we add a default color for the notification.

in my case the bg and fg were overlapped and the notification only shows full black, and after swapping the hl for NotificationInfo it works with displaying the guifg (because in the default colorscheme, i think only guibg are declared).

here are some comparison with different "default" colorscheme...

before the swap

Screenshot 2024-11-22 at 05 26 46
Screenshot 2024-11-22 at 05 34 16

after the swap

Screenshot 2024-11-22 at 05 25 42
Screenshot 2024-11-22 at 05 33 38

steps to reproduce

  1. change to default colorscheme (black background) or only have a guibg hl set
  2. run query

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant