Use admin client to confirm cluster is correctly started #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Barker <[email protected]>
Signed-off-by: Sam Barker <[email protected]>
Signed-off-by: Sam Barker <[email protected]>
|
Option 3 seems least worst to me. I prefer the clean separation of concerns that a dedicated listener gives us. It will be easier to identify in the logs too, which I expect we'll appreciate when debugging thorny issues. |
k-wall
reviewed
Feb 15, 2023
impl/src/main/java/io/kroxylicious/testing/kafka/common/Utils.java
Outdated
Show resolved
Hide resolved
k-wall
reviewed
Feb 15, 2023
impl/src/test/java/io/kroxylicious/testing/kafka/common/KafkaClusterConfigTest.java
Show resolved
Hide resolved
Signed-off-by: Sam Barker <[email protected]>
Signed-off-by: Sam Barker <[email protected]>
Signed-off-by: Sam Barker <[email protected]>
SamBarker
force-pushed
the
issue-7-using_awaitility
branch
from
b92cf1b to
0bcdc64
Compare
tombentley
approved these changes
Feb 16, 2023
impl/src/main/java/io/kroxylicious/testing/kafka/common/KafkaClusterConfig.java
Outdated
Show resolved
Hide resolved
impl/src/main/java/io/kroxylicious/testing/kafka/common/KafkaClusterConfig.java
Outdated
Show resolved
Hide resolved
impl/src/main/java/io/kroxylicious/testing/kafka/common/KafkaClusterConfig.java
Outdated
Show resolved
Hide resolved
| @@ -388,11 +434,23 @@ public interface KafkaEndpoints { | |||
| class EndpointPair { | |||
| private final Endpoint bind; | |||
| private final Endpoint connect; | |||
|
|
|||
| public String connectAddress() { | |||
| return String.format("%s:%d", connect.host, connect.port); | |||
There was a problem hiding this comment.
The %d is locale-dependent, according to the "Number Localization Algorithm" section in Formatter Javadoc, which says:
Each digit character d in the string is replaced by a locale-specific digit computed relative to the current locale's zero digit z;
To avoid this I would use concatenation using +.
There was a problem hiding this comment.
public char getZeroDigit()
Gets the character used for zero. Different for Arabic, etc.
Wow, I never knew that. I've written so much code that must fall on its face in the Arabic world.
| } | ||
|
|
||
| @Override | ||
| public EndpointPair getControllerEndpoint(int brokerId) { | ||
| // TODO why can't we treat ZK as the controller port outside of kraft mode? |
There was a problem hiding this comment.
Open an issue if this is worthy of further investigation.
There was a problem hiding this comment.
Opened #25 replied to wrong comment.
impl/src/main/java/io/kroxylicious/testing/kafka/invm/InVMKafkaCluster.java
Outdated
Show resolved
Hide resolved
impl/src/main/java/io/kroxylicious/testing/kafka/common/Utils.java
Outdated
Show resolved
Hide resolved
…ial into the cluster Signed-off-by: Sam Barker <[email protected]>
Co-authored-by: Tom Bentley <[email protected]>
…uster` Signed-off-by: Sam Barker <[email protected]>
Signed-off-by: Sam Barker <[email protected]>
Signed-off-by: Sam Barker <[email protected]>
Matches with kroxylicious-parent. Signed-off-by: Sam Barker <[email protected]>
SamBarker
force-pushed
the
issue-7-using_awaitility
branch
from
2269249 to
8475323
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses an admin client to describe the cluster and ensure the expected number of brokers are included before injecting into tests.
The one snag this faces is when authentication comes into play.
Initially I tried to connect to the inter-broker listener however that's not currently exposed to the host when running in test containers. So switched back to using the client listener. When that is authenticated the default admin client is unable to connect.
I see three possible solutions.
Separately I think there is some additional refactoring to do around how endpoints are defined and used to generate the various different formats of host and port required. i.e. clients don't like resolving
//localhost:9093and listeners don't likelocalhost:9093.Fixes #7