New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: document ready js template #3

Merged

t42ji2ji merged 1 commit into master from fix-document-start-script

Oct 11, 2023

a00012025 commented Oct 11, 2023 •

edited

Loading

Summary

比較 Metamask 用的 reaect native webview 跟 flutter_inappwebview 後，發現主要的差別在 inject 的 script 會被經過不同的處理才丟到 Android 的 evaluateJavascript

原本 flutter_inappwebview 裡的寫法，如果 inject 的當下 document.readyState = 'loading' 的話，script 就完全不會執行。把這個 template 改成 metamask 用的 IIFE 的寫法就會 work 了

主要參考：https://github.com/react-native-webview/react-native-webview/blob/master/android/src/main/java/com/reactnativecommunity/webview/RNCWebView.java#L284-L290


          fix: document ready js template

ff08b25

t42ji2ji approved these changes

View reviewed changes

t42ji2ji merged commit b0225c2 into master

1 of 3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet