Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highly skewed triangles - missed reflections - rays going outside the solid #75

Open
krzysztofarendt opened this issue Oct 16, 2024 · 6 comments
Open

Highly skewed triangles - missed reflections - rays going outside the solid #75

krzysztofarendt opened this issue Oct 16, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@krzysztofarendt
Copy link
Owner

For models with some highly skewed triangles (teapot.stl and cylinder.stl) rays occasionally go outside the solid.
Probably due to insufficient numerical precision.

image
@krzysztofarendt krzysztofarendt added the bug Something isn't working label Oct 16, 2024
@krzysztofarendt
Copy link
Owner Author

image

@krzysztofarendt
Copy link
Owner Author

Example of poor mesh quality in the teapot model:
teapot_from_the_inside

@krzysztofarendt
Copy link
Owner Author

image

@krzysztofarendt
Copy link
Owner Author

Tests show (cb34fac) that the triangle side length should be approximately >= 0.001.

@krzysztofarendt
Copy link
Owner Author

Related? #83

@krzysztofarendt krzysztofarendt mentioned this issue Oct 22, 2024
Closed
@krzysztofarendt
Copy link
Owner Author

This PR #88 still has this issue:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krzysztofarendt