Fix | Updated WorkflowEventSubscriber for fix #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orkflowEventSubscriber
|
@simple-hacker Thanks for the PR! Tests are failing here for the new changes -- we'll likely have to update them to support retrieving the class names of jobs. Will wait for Kai's approval on this, as I'm unsure if this is how he'd like to tackle this, and if he has a potentially better solution. |
|
Ah this is my mistake sorry, I didn't mean to do a PR here. I was meant to do a PR in my organisation's forked repo. I'll close this PR for now and will help investigate the issue properly and submit a better PR with passing tests. |
|
Ok sounds good, thanks @simple-hacker! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90 Using comment by @stevebauman
#90 (comment)
Return early if job does not implement WorkflowableJob interface in WorkflowEventSubscriber.