-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kinfer module #134
Update kinfer module #134
Conversation
WT-MM
commented
Dec 30, 2024
•
edited by budzianowski
Loading
edited by budzianowski
- Add back kinfer support
- Bring back imu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - getting there. See my comments for the cleanup.
sim/envs/base/legged_robot.py
Outdated
@@ -81,6 +81,7 @@ def step(self, actions): | |||
def reset(self): | |||
"""Reset all robots""" | |||
self.reset_idx(torch.arange(self.num_envs, device=self.device)) | |||
self._resample_default_positions() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have that already in the config start_pos_noise
.
See
sim/sim/envs/base/legged_robot.py
Line 385 in 8a63381
self.dof_pos[env_ids] = self.default_dof_pos + torch_rand_float( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start_pos_noise is different from randomly changing the default position though right?
The current thing with episode resets just tells the robot to have a diff init position but I also wanted to add some noise to the reference default position.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the point of adding noise to reference position that is ground truth?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because in real life there's some variance to the reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well we want that too right? the default dof pos randomization affects the model input and output
sim/envs/humanoids/gpr_config.py
Outdated
@@ -79,6 +168,9 @@ class noise_scales: | |||
quat = 0.03 | |||
height_measurements = 0.1 | |||
|
|||
class noise_ranges: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove - see my comment above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm (remove doubling the noise) - let's add this in before adding more changes.