Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kinfer module #134

Merged
merged 44 commits into from
Jan 3, 2025
Merged

Update kinfer module #134

merged 44 commits into from
Jan 3, 2025

Conversation

WT-MM
Copy link
Member

@WT-MM WT-MM commented Dec 30, 2024

  1. Add back kinfer support
  2. Bring back imu

@WT-MM WT-MM linked an issue Dec 30, 2024 that may be closed by this pull request
sim/play.py Outdated Show resolved Hide resolved
sim/play.py Outdated Show resolved Hide resolved
@budzianowski budzianowski self-requested a review December 30, 2024 23:38
@budzianowski budzianowski self-requested a review December 31, 2024 06:40
sim/play.py Outdated Show resolved Hide resolved
sim/sim2sim.py Outdated Show resolved Hide resolved
@budzianowski budzianowski self-requested a review January 2, 2025 17:25
Copy link
Collaborator

@budzianowski budzianowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - getting there. See my comments for the cleanup.

@@ -81,6 +81,7 @@ def step(self, actions):
def reset(self):
"""Reset all robots"""
self.reset_idx(torch.arange(self.num_envs, device=self.device))
self._resample_default_positions()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have that already in the config start_pos_noise.
See

self.dof_pos[env_ids] = self.default_dof_pos + torch_rand_float(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start_pos_noise is different from randomly changing the default position though right?

The current thing with episode resets just tells the robot to have a diff init position but I also wanted to add some noise to the reference default position.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of adding noise to reference position that is ground truth?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because in real life there's some variance to the reference

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to test that then change the code cause right now start_pos_noise randomly adds noise to the default position
Screenshot 2025-01-02 at 16 00 57

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well we want that too right? the default dof pos randomization affects the model input and output

sim/envs/humanoids/gpr_config.py Outdated Show resolved Hide resolved
@@ -79,6 +168,9 @@ class noise_scales:
quat = 0.03
height_measurements = 0.1

class noise_ranges:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove - see my comment above

sim/envs/humanoids/gpr_config.py Show resolved Hide resolved
@budzianowski budzianowski self-requested a review January 2, 2025 23:53
Copy link
Collaborator

@budzianowski budzianowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm (remove doubling the noise) - let's add this in before adding more changes.

@WT-MM WT-MM enabled auto-merge (squash) January 3, 2025 01:01
@WT-MM WT-MM merged commit c1712ac into master Jan 3, 2025
1 check passed
@WT-MM WT-MM deleted the kinfer-schema branch January 3, 2025 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update kinfer in sim
3 participants