new consts + updated consts names #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golanha
requested changes
Dec 2, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Adir111)
lib/pod-statuses.js line 5 at r1 (raw file):
NOT_EXIST: 'NOT_EXIST', ALG0_RUNNER_NO_IMAGE: 'ALGO_RUNNER_NO_IMAGE', ALGO_RUNNER_ERROR: 'ALGO_RUNNER_ERROR',
ALGORUNNER is always as one word in our code
Code quote:
ALGO_RUNNER_ERROR',
Adir111
commented
Dec 2, 2024
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @golanha)
lib/pod-statuses.js line 5 at r1 (raw file):
Previously, golanha (Golan Hallel) wrote…
ALGORUNNER is always as one word in our code
Done.
Also, changed SIDE_CAR to SIDECAR for the same reason.
golanha
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Adir111)
github-actions bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
new consts + updated consts names (#20) .... bump version [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added sidecar error and no image consts, and separated from algo runner error and no image consts.
Needed for the following PR - kube-HPC/hkube#2033
Related issue - kube-HPC/hkube#1821
This change is