Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoscaler interval log #2009

Merged
merged 93 commits into from
Nov 11, 2024
Merged

autoscaler interval log #2009

merged 93 commits into from
Nov 11, 2024

Conversation

RonShvarz
Copy link
Contributor

@RonShvarz RonShvarz commented Sep 16, 2024

#2002


This change is Reviewable

@RonShvarz
Copy link
Contributor Author

/deploy test

@RonShvarz
Copy link
Contributor Author

/deploy test

@RonShvarz
Copy link
Contributor Author

/deploy test

@RonShvarz
Copy link
Contributor Author

/deploy test

@Adir111
Copy link
Contributor

Adir111 commented Sep 19, 2024

/deploy test

@Adir111
Copy link
Contributor

Adir111 commented Sep 19, 2024

/deploy test

@Adir111
Copy link
Contributor

Adir111 commented Sep 19, 2024

/deploy test

@Adir111
Copy link
Contributor

Adir111 commented Sep 19, 2024

/deploy test

@Adir111
Copy link
Contributor

Adir111 commented Sep 19, 2024

/deploy test

@Adir111
Copy link
Contributor

Adir111 commented Oct 31, 2024

/deploy

@Adir111
Copy link
Contributor

Adir111 commented Oct 31, 2024

/deploy

@Adir111
Copy link
Contributor

Adir111 commented Oct 31, 2024

/deploy

@Adir111
Copy link
Contributor

Adir111 commented Nov 3, 2024

/deploy

@Adir111
Copy link
Contributor

Adir111 commented Nov 3, 2024

/deploy

Copy link
Member

@golanha golanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Adir111 and @RonShvarz)

@Adir111 Adir111 merged commit 44e0c1a into master Nov 11, 2024
5 checks passed
@Adir111 Adir111 deleted the streaming-logs-scaleupspeed branch November 11, 2024 07:55
hkube-ci pushed a commit that referenced this pull request Nov 11, 2024
* autoscaler interval log

* updated gitflow deprecated download-artifact@v2

* added actual task # added

* task executor log message

* decorator for logs

* added algo name + count of algos.

* removed redundant logging

* fixed total calculation

* removed underscore

* total sum

* removed total algorithms logging

* log required cutoff by maxReplicasPerTick

* round trip based secondary scale

* use round trip and not duration.

* wait for both round trip and reqrate

* scaling logic changed

* init value

* updated scale logic

* removed unused

* no need to scale if value remained the same

* changed to array

* updated scaling logic

* logging has been added again

* added scaling to 0

* fixed 0 not being proccessed

* added doc

* corrected if

* refactor

* clean-up un-used codes

* jsdoc added

* unused code

* unused code

* updated tests

* removed redundent conditions

* additional condition

* changed to config value

* removed timeout (added for a check)

* changed scale up condition

* scale up amount changed

* changed scale up condition

* undo last change

* added logging

* logging

* added _ since prop didnt exist

* redundent, being handled in auto-scaler

* changed condition to scale up

* added logging

* added logging

* removed =

* removed unused code

* removed unused code

* avg of round trip (array)

* removed total logging

* fixed bug

* added dynamic max size to fixed-window

* wip

* fix problematic value

* logging

* logging fixed

* fixed error

* fix

* not needed, changed back

* Now not scaling down in case there is queue

* removed for checking

* undo last check

* undo for check

* removed for checking

* corrected config access

* added config parameter for debugging purposes

* unused

* removed unused

* fixed

* fix

* wip

* logging

* fix config logic

* fixed logging

* updated config value

* updated config value

* revert window change update

* queue empty when less then 1 sec

* fixed config debug check

* removed old logging used for checking

* fixed reaching undefined value

* removed (used for debugging)

* changed window size

* not needed

---------

Co-authored-by: Adir111 <[email protected]>
Co-authored-by: Adir David <[email protected]> .... bump version [skip ci]
hkube-ci pushed a commit that referenced this pull request Nov 11, 2024
* autoscaler interval log

* updated gitflow deprecated download-artifact@v2

* added actual task # added

* task executor log message

* decorator for logs

* added algo name + count of algos.

* removed redundant logging

* fixed total calculation

* removed underscore

* total sum

* removed total algorithms logging

* log required cutoff by maxReplicasPerTick

* round trip based secondary scale

* use round trip and not duration.

* wait for both round trip and reqrate

* scaling logic changed

* init value

* updated scale logic

* removed unused

* no need to scale if value remained the same

* changed to array

* updated scaling logic

* logging has been added again

* added scaling to 0

* fixed 0 not being proccessed

* added doc

* corrected if

* refactor

* clean-up un-used codes

* jsdoc added

* unused code

* unused code

* updated tests

* removed redundent conditions

* additional condition

* changed to config value

* removed timeout (added for a check)

* changed scale up condition

* scale up amount changed

* changed scale up condition

* undo last change

* added logging

* logging

* added _ since prop didnt exist

* redundent, being handled in auto-scaler

* changed condition to scale up

* added logging

* added logging

* removed =

* removed unused code

* removed unused code

* avg of round trip (array)

* removed total logging

* fixed bug

* added dynamic max size to fixed-window

* wip

* fix problematic value

* logging

* logging fixed

* fixed error

* fix

* not needed, changed back

* Now not scaling down in case there is queue

* removed for checking

* undo last check

* undo for check

* removed for checking

* corrected config access

* added config parameter for debugging purposes

* unused

* removed unused

* fixed

* fix

* wip

* logging

* fix config logic

* fixed logging

* updated config value

* updated config value

* revert window change update

* queue empty when less then 1 sec

* fixed config debug check

* removed old logging used for checking

* fixed reaching undefined value

* removed (used for debugging)

* changed window size

* not needed

---------

Co-authored-by: Adir111 <[email protected]>
Co-authored-by: Adir David <[email protected]> .... bump version [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants