Pipeline versioning tests #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golanha
requested changes
Nov 11, 2024
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Adir111)
core/api-server/tests/pipelines-versions.js line 58 at r1 (raw file):
}); it.only('should succeed to get versions and change version to latest', async () => {
Remove the "only"
Code quote:
.only
Adir111
commented
Nov 11, 2024
There was a problem hiding this comment.
Reviewable status: 6 of 7 files reviewed, 1 unresolved discussion (waiting on @golanha)
core/api-server/tests/pipelines-versions.js line 58 at r1 (raw file):
Previously, golanha (Golan Hallel) wrote…
Remove the "only"
Done.
golanha
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Adir111)
hkube-ci
pushed a commit
that referenced
this pull request
Nov 14, 2024
* fixed bug * changed file name * fixed bug * bug fix * added tests for pipelines versioning * added deletion tests * removed deletion * fixed test * fixed test * moved line * return new pipeline when updating pipeline * updated test * removed .only * added validation for semver increasement of latest version .... bump version [skip ci]
hkube-ci
pushed a commit
that referenced
this pull request
Nov 14, 2024
* fixed bug * changed file name * fixed bug * bug fix * added tests for pipelines versioning * added deletion tests * removed deletion * fixed test * fixed test * moved line * return new pipeline when updating pipeline * updated test * removed .only * added validation for semver increasement of latest version .... bump version [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for recently added feature - pipeline versioning.
Also fixed few problems found.
Issue: #2012
This change is