-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
teams rewrite secret/env functionality #3799
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if we should take a stand here a split out rbac from having duplicate entries in saml and oidc
e85b0e6
to
c9037dc
Compare
@Sean-Holcomb @kaelanspatel what do we need to do to make progress here? Never opposed to simplifying the Helm values, but if that'll add ~days to the cycle getting this merged, I'd ask to take that stand another time. We have folks waiting on the new and improved RBAC capabilities. |
@nealormsbee Just simplifying and testing the config this morning, should be done with it and a draft for the associated setup docs by EoD today. |
You the man! Thanks. |
For posterity, latest change adds/changes:
|
Bumping this one gents. Looks like the lint checker is just failing on two bad links in the README. |
Not sure but I think that the README links should be updated to |
Signed-off-by: Sean Holcomb <[email protected]>
Signed-off-by: Sean Holcomb <[email protected]>
Signed-off-by: Neal Ormsbee <[email protected]>
efca96c
to
a35757c
Compare
What does this PR change?
Implements supporting helm changes for new RBAC teams. This includes token signing secret and teams helm config configmap mountings, env var configuration, and a config block in Values.yaml.
Does this PR rely on any other PRs?
See linked KCM PR.
How does this PR impact users? (This is the kind of thing that goes in release notes!)
See linked KCM PR.
Links to Issues or tickets this PR addresses or fixes
Adds ability to configure new Teams functionality in 2.6.0, including enable/disable, blocking invalid configurations of rbac, and configuring teams via helm values and/or mounting a secret.
What risks are associated with merging this PR? What is required to fully test this PR?
The risks are likely minimal, though testing should be performed for downgrade/upgrade scenarios.
How was this PR tested?
See linked KCM PR for general auth testing.
Tested no-rbac auth config, simple rbac auth config, self-created configmap config, and config with helm-created configmap.
Have you made an update to documentation? If so, please provide the corresponding PR.
In progress.