Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing url in grafana datasource #3812

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

takirala
Copy link

@takirala takirala commented Jan 16, 2025

What does this PR change?

grafana-datasource configmap is being created with invalid datasource as the url is empty. I think this was an overlook when thanos support was removed (in 279d7be#diff-406c7314a1029b6fe683e8a2c4bf1f7f52222794f542eb30a5a0aec78e022e28). Please let me know if I am missing some context.

Does this PR rely on any other PRs?

How does this PR impact users? (This is the kind of thing that goes in release notes!)

  • Fixes the url in grafana datasource configmap when using an external grafana using the sidecar.

Links to Issues or tickets this PR addresses or fixes

What risks are associated with merging this PR? What is required to fully test this PR?

  • Create a kubecost cluster by disabling in-built grafana and configure an external grafana. The datasource will be created with an invalid value. Adding the fix in this PR will make the datasource work correctly.

How was this PR tested?

I updated the configmap for grafana-datasource and was able to browse grafana correctly.

Have you made an update to documentation? If so, please provide the corresponding PR.

@takirala takirala marked this pull request as ready for review January 16, 2025 20:44
@takirala
Copy link
Author

Ping @jessegoodier @ivankube @cliffcolvin PTAL 🙏
I am not sure i pinged the right people, please redirect as needed, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant