fix: add missing url in grafana datasource #3812
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
grafana-datasource
configmap is being created with invalid datasource as the url is empty. I think this was an overlook when thanos support was removed (in 279d7be#diff-406c7314a1029b6fe683e8a2c4bf1f7f52222794f542eb30a5a0aec78e022e28). Please let me know if I am missing some context.Does this PR rely on any other PRs?
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Links to Issues or tickets this PR addresses or fixes
What risks are associated with merging this PR? What is required to fully test this PR?
How was this PR tested?
I updated the configmap for grafana-datasource and was able to browse grafana correctly.
Have you made an update to documentation? If so, please provide the corresponding PR.