Add teamsError.html to nginx routing #3827
Merged
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik-kc
approved these changes
Jan 31, 2025
|
/cherry-pick v2.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Adds a route for the teamsError page introduced in https://github.com/kubecost/kubecost-frontend/pull/2377 outside of the auth handling so it can be served to unauthorized users.
Does this PR rely on any other PRs?
https://github.com/kubecost/kubecost-frontend/pull/2377
How does this PR impact users? (This is the kind of thing that goes in release notes!)
No release notes impact.
Links to Issues or tickets this PR addresses or fixes
What risks are associated with merging this PR? What is required to fully test this PR?
Should be no risk.
How was this PR tested?
Tested by manually editing live nginx config with changes.
Have you made an update to documentation? If so, please provide the corresponding PR.