Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Al-Pragliola as a member #722

Merged

Conversation

Al-Pragliola
Copy link
Contributor

@Al-Pragliola Al-Pragliola commented Nov 11, 2024

Pytest output

$ pytest test_org_yaml.py
===================================================================================== test session starts =====================================================================================
platform linux -- Python 3.12.7, pytest-7.4.3, pluggy-1.3.0
rootdir: /home/apraglio/Work/internal-acls/github-orgs
plugins: anyio-4.6.2.post1
collected 1 item

test_org_yaml.py .                                                                                                                                                                      [100%]

====================================================================================== 1 passed in 0.07s ======================================================================================

Sponsoring members

Matteo Mortari - @tarilabs

Contributions

Copy link

Hi @Al-Pragliola. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tarilabs
Copy link
Member

I confirm I'm happy to sponsor this request!

/lgtm

@juliusvonkohout
Copy link
Member

@kubeflow/kubeflow-steering-committee for approval and @zijianjoy

@Al-Pragliola Al-Pragliola marked this pull request as ready for review November 11, 2024 17:53
@google-oss-prow google-oss-prow bot requested a review from jbottum November 11, 2024 17:53
Signed-off-by: Alessio Pragliola <[email protected]>
@Al-Pragliola Al-Pragliola force-pushed the feat/add-al-pragliola-to-members branch from 9b4c469 to 5df0741 Compare November 25, 2024 16:58
@google-oss-prow google-oss-prow bot removed the lgtm label Nov 25, 2024
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great contributions @Al-Pragliola!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 7b54b8d into kubeflow:master Nov 26, 2024
3 checks passed
@Al-Pragliola Al-Pragliola deleted the feat/add-al-pragliola-to-members branch November 26, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants