Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove some unused deprecated libraries (react-axe and react-docgen-typescript-loader) #192

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

ederign
Copy link
Member

@ederign ederign commented Jul 15, 2024

Remove some unused deprecated libraries from our package json

Description

react-axe: help to fix and identify accessibility issues. The project was moved to another org so we will need to add them back later.
react-docgen-typescript-loader: it's not necessary. Leftover from the seed project

How Has This Been Tested?

➜  frontend git:(main) ✗ npm install                                                                                                                  (kind-kubebuilder-cluster/default)

up to date, audited 1199 packages in 720ms

210 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
➜  frontend git:(main) ✗ npm audit                                                                                                                    (kind-kubebuilder-cluster/default)
found 0 vulnerabilities

Merge criteria:

  • [X ] The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • [ X] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • [ X] The developer has manually tested the changes and verified that the changes work

…ocgen-typescript-loader)

Signed-off-by: Eder Ignatowicz <[email protected]>
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Eder,

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 5af99c4 into kubeflow:main Jul 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants