Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(go): bump golang version to 1.22 #689

Merged

Conversation

Al-Pragliola
Copy link
Contributor

@Al-Pragliola Al-Pragliola commented Jan 7, 2025

Description

According to the golang release policy,
golang 1.21 had the last security fixes released in go1.21.13 (2024-08-06), so I propose to bump golang's version to the next supported major (1.22) to improve security coverage.

How Has This Been Tested?

make test

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

@Al-Pragliola Al-Pragliola force-pushed the al-pragliola-bump-golang-1-22 branch from c95bfe2 to d5e3fbd Compare January 7, 2025 15:53
@Al-Pragliola
Copy link
Contributor Author

/cc @tarilabs

@google-oss-prow google-oss-prow bot requested a review from tarilabs January 15, 2025 21:44
@tarilabs
Copy link
Member

thanks @Al-Pragliola , good with me, cc @pboyd @dhirajsb

@pboyd
Copy link
Contributor

pboyd commented Jan 21, 2025

We'll have to do this again in a couple weeks (https://tip.golang.org/doc/go1.24). Any interest in going straight to 1.23?

@Al-Pragliola
Copy link
Contributor Author

We'll have to do this again in a couple weeks (https://tip.golang.org/doc/go1.24). Any interest in going straight to 1.23?

the only thing that may be a problem is that another repo is importing a /pkg from there and they are using go 1.22

@pboyd
Copy link
Contributor

pboyd commented Jan 21, 2025

As long as we don't use any 1.23-specific features, it should be compatible. But no rush, I suppose, that other project will probably need to upgrade soon anyway.

@ederign
Copy link
Member

ederign commented Jan 22, 2025

Guys, just FYI, I'm proposing to bump it to 1.23.5 on the BFF. #727 (/cc @alexcreasy )

@Al-Pragliola
Copy link
Contributor Author

let's proceed sequentially I'd merge first this one and than next release we can go for 1.23, wdyt? @pboyd

Copy link
Contributor

@pboyd pboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me @Al-Pragliola. /lgtm (I don't think I can tag the PR though)

@tarilabs
Copy link
Member

Fine with me @Al-Pragliola. /lgtm (I don't think I can tag the PR though)

I believe /lgtm is permissive, only approval that requires being in the approvals of owners

thanks a lot to you all
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pboyd, tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 822028f into kubeflow:main Jan 28, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants