-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(go): bump golang version to 1.22 #689
chore(go): bump golang version to 1.22 #689
Conversation
Signed-off-by: Alessio Pragliola <[email protected]>
c95bfe2
to
d5e3fbd
Compare
/cc @tarilabs |
thanks @Al-Pragliola , good with me, cc @pboyd @dhirajsb |
We'll have to do this again in a couple weeks (https://tip.golang.org/doc/go1.24). Any interest in going straight to 1.23? |
the only thing that may be a problem is that another repo is importing a /pkg from there and they are using go 1.22 |
As long as we don't use any 1.23-specific features, it should be compatible. But no rush, I suppose, that other project will probably need to upgrade soon anyway. |
Guys, just FYI, I'm proposing to bump it to 1.23.5 on the BFF. #727 (/cc @alexcreasy ) |
let's proceed sequentially I'd merge first this one and than next release we can go for 1.23, wdyt? @pboyd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me @Al-Pragliola. /lgtm (I don't think I can tag the PR though)
I believe thanks a lot to you all |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pboyd, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
According to the golang release policy,
golang 1.21 had the last security fixes released in go1.21.13 (2024-08-06), so I propose to bump golang's version to the next supported major (1.22) to improve security coverage.
How Has This Been Tested?
make test
Merge criteria:
DCO
check)