Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

support set volcano queue name #357

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qiankunli
Copy link

@qiankunli qiankunli commented Sep 23, 2021

Signed-off-by: bert.li [email protected]
pytorch-operator will create podgroup when reconcile tfjob, but the queue of created podgroup is always "default". I want create podgroup with queue, like mpi-operator, so

  1. create pytorchjob with annotation scheduling.volcano.sh/queue-name
  2. parse queue from the annotation when create podgoup

PyTorchController use JobController.SyncPodGroup to create podgroup and I can not edit it, so I copy JobController.SyncPodGroup to PyTorchController

@aws-kf-ci-bot
Copy link

Hi @qiankunli. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign andreyvelich after the PR has been reviewed.
You can assign the PR to them by writing /assign @andreyvelich in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants