Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the exception message semantically to align with the conditional. #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adjust the exception message semantically to align with the conditional. #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6bf54a
Adjust the exception message semantically to align with the TLS condi…
jonatasemidio Sep 27, 2024
9c426fa
Merge branch 'main' into patch-1
jonatasemidio Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions kubemq-java-springboot/src/main/java/io/kubemq/sdk/client/KubeMQClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,10 @@ public abstract class KubeMQClient implements AutoCloseable {
public KubeMQClient(String address, String clientId, String authToken, boolean tls, String tlsCertFile, String tlsKeyFile, String caCertFile,
int maxReceiveSize, int reconnectIntervalSeconds, Boolean keepAlive, int pingIntervalInSeconds, int pingTimeoutInSeconds, Level logLevel) {
if (address == null || clientId == null) {
throw new IllegalArgumentException("Address and clientId are required");
throw new IllegalArgumentException("Address or clientId are required");
}
// if (tls && (tlsCertFile == null || tlsKeyFile == null)) {
// throw new IllegalArgumentException("When TLS is enabled, tlsCertFile and tlsKeyFile are required");
// throw new IllegalArgumentException("When TLS is enabled, tlsCertFile and tlsKeyFile are required"); // In this case the message could be: When TLS is enabled, tlsCertFile or tlsKeyFile is required
// }

this.address = address;
Expand Down