Skip to content

Commit

Permalink
remove unused function (#4821)
Browse files Browse the repository at this point in the history
Signed-off-by: zcq98 <[email protected]>
  • Loading branch information
zhaocongqi authored Dec 18, 2024
1 parent 96ad245 commit 0a8adbf
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 17 deletions.
4 changes: 0 additions & 4 deletions pkg/ovs/ovn-nb-suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1231,10 +1231,6 @@ func (suite *OvnClientTestSuite) Test_OvsCleanDuplicatePort() {
suite.testOvsCleanDuplicatePort()
}

func (suite *OvnClientTestSuite) Test_OvsSetPortTag() {
suite.testOvsSetPortTag()
}

func (suite *OvnClientTestSuite) Test_ValidatePortVendor() {
suite.testValidatePortVendor()
}
Expand Down
4 changes: 0 additions & 4 deletions pkg/ovs/ovs-vsctl.go
Original file line number Diff line number Diff line change
Expand Up @@ -288,10 +288,6 @@ func CleanDuplicatePort(ifaceID, portName string) {
}
}

func SetPortTag(port, tag string) error {
return ovsSet("port", port, fmt.Sprintf("tag=%s", tag))
}

// ValidatePortVendor returns true if the port's external_ids:vendor=kube-ovn
func ValidatePortVendor(port string) (bool, error) {
output, err := ovsFind("Port", "name", "external_ids:vendor="+util.CniTypeName)
Expand Down
9 changes: 0 additions & 9 deletions pkg/ovs/ovs-vsctl_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -177,15 +177,6 @@ func (suite *OvnClientTestSuite) testOvsCleanDuplicatePort() {
CleanDuplicatePort("iface-id", "port-name")
}

func (suite *OvnClientTestSuite) testOvsSetPortTag() {
t := suite.T()
t.Parallel()

err := SetPortTag("port-name", "tag")
// ovs-vsctl cmd is not available in the test environment
require.Error(t, err)
}

func (suite *OvnClientTestSuite) testValidatePortVendor() {
t := suite.T()
t.Parallel()
Expand Down

0 comments on commit 0a8adbf

Please sign in to comment.