add base rules for allowing vrrp packets #3293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yuanliu <[email protected]>
bobz965
approved these changes
Oct 12, 2023
bobz965
pushed a commit
that referenced
this pull request
Oct 12, 2023
Signed-off-by: yuanliu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes:
Fixes #3292
WHAT
🤖 Generated by Copilot at 59ecef0
Enhance security group rules for IPv6 and VRRP packets in
ovn-nb-acl.go. Add variables and match conditions to allow ICMPv6 and VRRP traffic within port groups.🤖 Generated by Copilot at 59ecef0
HOW
🤖 Generated by Copilot at 59ecef0
icmpv6Typeto store the allowed ICMPv6 types for ingress and egress rules (link)icmpv6Typein theicmpv6Matchcondition instead of hard-coded values (link)vrrpMatchfor VRRP packets in the same security group (link)