-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support ovn ic ecmp #3348
Merged
Merged
support ovn ic ecmp #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a3b44a0
to
88a9581
Compare
E2E test should be added. |
zhangzujian
reviewed
Nov 3, 2023
1 |
Need update the docs to describe new usage |
7b9b39a
to
c89a140
Compare
STEP: Waiting for ecmp gateway to be applied @ 11/08/23 11:08:02.839
[FAILED] in [It] - /home/runner/work/kube-ovn/kube-ovn/test/e2e/ovn-ic/e2e_test.go:260 @ 11/08/23 11:08:18.27
STEP: Destroying namespace "ovn-ic-6110" for this suite. @ 11/08/23 11:08:18.271
STEP: Destroying namespace "ovn-ic-1050" for this suite. @ 11/08/23 11:08:18.274
<< Timeline
[FAILED] Expected
<int>: 6
to equal
<int>: 3
In [It] at: /home/runner/work/kube-ovn/kube-ovn/test/e2e/ovn-ic/e2e_test.go:260 @ 11/08/23 11:08:18.27 |
b892f04
to
bbb2389
Compare
bbb2389
to
4a15bee
Compare
zhangzujian
reviewed
Nov 9, 2023
zhangzujian
reviewed
Nov 9, 2023
zhangzujian
reviewed
Nov 9, 2023
zhangzujian
reviewed
Nov 9, 2023
zhangzujian
reviewed
Nov 9, 2023
zhangzujian
reviewed
Nov 10, 2023
zhangzujian
reviewed
Nov 10, 2023
zhangzujian
approved these changes
Nov 13, 2023
need rebase |
Signed-off-by: changluyi <[email protected]>
Signed-off-by: changluyi <[email protected]>
Signed-off-by: Changlu Yi <[email protected]>
Signed-off-by: changluyi <[email protected]>
Signed-off-by: changluyi <[email protected]>
Signed-off-by: Changlu Yi <[email protected]>
Signed-off-by: Changlu Yi <[email protected]>
Signed-off-by: Changlu Yi <[email protected]>
Signed-off-by: Changlu Yi <[email protected]>
Signed-off-by: Changlu Yi <[email protected]>
Signed-off-by: changluyi <[email protected]>
Signed-off-by: changluyi <[email protected]>
7e0ab51
to
a92d95e
Compare
1 |
changluyi
added a commit
that referenced
this pull request
Nov 14, 2023
* support ovn ic ecmp Signed-off-by: changluyi <[email protected]>
changluyi
added a commit
that referenced
this pull request
Nov 14, 2023
* support ovn ic ecmp Signed-off-by: changluyi <[email protected]>
zbb88888
pushed a commit
that referenced
this pull request
Nov 14, 2023
* support ovn ic ecmp Signed-off-by: changluyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes:
Fixes #(issue-number)
WHAT
🤖 Generated by Copilot at 0efe216
This pull request implements and tests the new design of the interconnection feature for kind clusters, which uses multiple logical switches and ports instead of one shared switch and port. It also fixes a dependency issue with the k8s.io/endpointslice module and adds some comments and external IDs to improve the code readability and reliability. The changes affect the
Makefile
,mocks/pkg/ovs/interface.go
,pkg/controller/ovn-ic.go
,test/e2e/ovn-ic/e2e_test.go
,go.mod
,pkg/ovs/interface.go
,pkg/ovs/ovn-nb-logical_router_policy.go
, andyamls/kind.yaml.j2
files.🤖 Generated by Copilot at 0efe216
HOW
🤖 Generated by Copilot at 0efe216
establishInterConnection
function to create one logical switch and one logical patch port for each gateway node, and to simplify the logic (link, link)waitTsReady
function, which is no longer needed (link)waitTsReady
function with thecreateTS
function, which creates a logical switch with the external ID of the subnet (link)syncOneRouteToPolicy
function to use theGetLogicalRouterPoliciesByExtID
method, which gets the logical router policies by the external ID of the cluster, and to improve the performance and readability of the code (link, link)GetLogicalRouterPoliciesByExtID
method to theLogicalRouterPolicy
andNbClient
interfaces, and implement the method in theovn-nb-logical_router_policy.go
file (link, link, link, link)removeInterConnection
function to comment out some lines that delete the logical router ports and the logical switches, and to add a TODO comment to use external ID to delete ports (link)startOvnIC
andstopOvnIC
functions tostartOVNIC
andstopOVNIC
, and remove some redundant error logs (link, link, link)acquireLrpAddress
function to fix some typos in the error messages, and to remove the line that checks the protocol of the logical switch port address (link)github.com/kubeovn/kube-ovn/pkg/ovs
package to thepkg/controller/ovn-ic.go
file (link)yamls/kind.yaml.j2
file to specify that the node is a worker node, and to set the image to the kindest/node with the k8s version variable (link)