Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube-ovn-cni: fix pinger result when timeout is reached #3457

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Nov 24, 2023

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

W1124 16:21:39.705812 1626079 ovs.go:34] 10.100.6.9 network not ready after 189 ping to gateway 10.100.6.1
W1124 16:21:42.705081 1626079 ovs.go:34] 10.100.6.9 network not ready after 192 ping to gateway 10.100.6.1
W1124 16:21:45.705465 1626079 ovs.go:34] 10.100.6.9 network not ready after 195 ping to gateway 10.100.6.1
W1124 16:21:48.706072 1626079 ovs.go:34] 10.100.6.9 network not ready after 198 ping to gateway 10.100.6.1
I1124 16:21:50.754492 1626079 ovs.go:45] 10.100.6.9 network ready after 200 ping, gw 10.100.6.1

WHAT

🤖[deprecated] Generated by Copilot at 7aa7fe9

Improve network readiness check by handling gateway ping failure. Add error return and warning log in pingGateway function in pkg/daemon/ovs.go.

🤖[deprecated] Generated by Copilot at 7aa7fe9

pingGateway checks
packets from the gateway - none?
logs a warning, fails

HOW

🤖[deprecated] Generated by Copilot at 7aa7fe9

  • Add a check for gateway packet loss in pingGateway function (link) to improve error handling and logging of network readiness

@zhangzujian zhangzujian added bug Something isn't working need backport labels Nov 24, 2023
@zhangzujian zhangzujian merged commit 07798be into kubeovn:master Nov 24, 2023
60 checks passed
@zhangzujian zhangzujian deleted the fix-ping branch November 24, 2023 10:19
zhangzujian added a commit that referenced this pull request Nov 24, 2023
zhangzujian added a commit that referenced this pull request Nov 24, 2023
bobz965 pushed a commit that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants