e2e aap for security group #3459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaocongqi
force-pushed
the
e2e-aap-sg
branch
2 times, most recently
from
f3610b1 to
e6f7274
Compare
zbb88888
requested changes
Nov 30, 2023
test/e2e/vip/e2e_test.go
Outdated
| allowAddress := aapPod1.Annotations[util.IPAddressAnnotation] | ||
| routes := make([]*apiv1.SgRule, 0, 2) | ||
| // gateway should be added for pinger | ||
| routes = append(routes, &apiv1.SgRule{ |
Signed-off-by: zcq98 <[email protected]>
zhaocongqi
force-pushed
the
e2e-aap-sg
branch
from
e6f7274 to
c6b4531
Compare
oilbeater
approved these changes
Dec 5, 2023
zbb88888
pushed a commit
that referenced
this pull request
Dec 5, 2023
Signed-off-by: zcq98 <[email protected]> Co-authored-by: zcq98 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
This feature was introduced in v1.13
Which issue(s) this PR fixes
WHAT
🤖[deprecated] Generated by Copilot at 4141519
This pull request enhances the e2e tests for the
vipfeature of kube-ovn by adding security group support and testing scenarios with AAP pods. It also adds a new filetest/e2e/framework/security-group.goto provide a common interface for creating and managing security groups in the tests. Additionally, it fixes a typo in an error message intest/e2e/framework/vip.go.🤖[deprecated] Generated by Copilot at 4141519
HOW
🤖[deprecated] Generated by Copilot at 4141519
test/e2e/framework/security-group.gothat defines aSecurityGroupClientstruct and its methods for managing security groups, and a helper functionMakeSecurityGroupto create a security group object (F0)DeleteSyncmethod of theVipClientstruct intest/e2e/framework/vip.go(link)MakeSecurityGroupto thevippackage intest/e2e/vip/e2e_test.gothat wraps the framework function and returns akubeovnv1.SecurityGroupobject (link)securityGroupClientof type*framework.SecurityGroupClientto thevippackage intest/e2e/vip/e2e_test.goto create and manage security groups in thevipe2e tests (link, link)aapPodName3andsecurityGroupNameof typestringto thevippackage intest/e2e/vip/e2e_test.goto store the names of a third AAP pod and a security group for testing the connectivity of AAP pods (link, link)aapPodName3pod in theAfterEachblock of thevipe2e tests to clean up the resources (link)CreateSyncmethod to theaapPod1andaapPod2variables in theItblock of thevipe2e tests to store the updated pod objects with annotations (link)MakeSecurityGroupfunction and thesecurityGroupNamevariable (link)