Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: github action cannot ping 114 #3486

Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix: github action cannot ping 114 #3486

merged 1 commit into from
Dec 4, 2023

Conversation

oilbeater
Copy link
Collaborator

@oilbeater oilbeater commented Dec 4, 2023

Pull Request

What type of this PR

Examples of user facing changes:

  • Tests

Which issue(s) this PR fixes

Fixes #(issue-number)

WHAT

🤖[deprecated] Generated by Copilot at f9d56d6

This pull request replaces the external IP addresses used by the kube-ovn-pinger pod and the network connectivity tests with more reliable and available ones. It changes the --external-address argument and the PINGER_EXTERNAL_ADDRESS parameter in various files to use 1.1.1.1 for IPv4 and 2606:4700:4700::1111 for IPv6.

🤖[deprecated] Generated by Copilot at f9d56d6

Oh we are the pingers of the kube-ovn
We test the network from dusk till dawn
We heave and we ho and we change the --external-address
To 1.1.1.1 and 2606:4700:4700::1111

HOW

🤖[deprecated] Generated by Copilot at f9d56d6

  • Change the default external IP address for network connectivity testing from 114.114.114.114 and 2400:3200::1 to 1.1.1.1 and 2606:4700:4700::1111 in the following files and parameters:
  • charts/values.yaml for the PINGER_EXTERNAL_ADDRESS parameter (link,link,link)
  • pkg/pinger/config.go for the argExternalAddress flag (link)
  • test/e2e/kube-ovn/kubectl-ko/kubectl-ko.go for the externalIP variable (link)
  • test/e2e/kube-ovn/subnet/subnet.go for the externalIP variable (link,link)
  • yamls/kube-ovn-dual-stack.yaml and yamls/kube-ovn.yaml for the --external-address argument (link,link)

@oilbeater oilbeater added the test automation tests label Dec 4, 2023
@oilbeater oilbeater merged commit 8628642 into master Dec 4, 2023
60 checks passed
@oilbeater oilbeater deleted the fix/ping-external branch December 4, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test automation tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant