try fix fip not work for default vpc #3666
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangzujian
reviewed
Jan 24, 2024
|
从 issue 讨论的日志来看，使用 annotation 也是加的路由 只是被 policy based route 覆盖了？ |
Signed-off-by: HuangWei <[email protected]>
Co-authored-by: 张祖建 <[email protected]> Signed-off-by: HuangWei <[email protected]>
use c.config.ClusterRouter instead of defaultVPC const Signed-off-by: HuangWei <[email protected]>
zbb88888
requested changes
Jan 26, 2024
pkg/controller/ovn_fip.go
Outdated
| @@ -421,6 +421,28 @@ func (c *Controller) handleUpdateOvnFip(key string) error { | |||
| return err | |||
| } | |||
| // ovn add fip | |||
| if vpcName == c.config.ClusterRouter { | |||
| // fix issue https://github.com/kubeovn/kube-ovn/issues/3502 | |||
pkg/controller/ovn_fip.go
Outdated
| klog.Errorf("failed to create config map %s, %v", util.ExternalGatewayConfig, err) | ||
| return err | ||
| } | ||
| externalGwAddr := cm.Data["external-gw-addr"] |
There was a problem hiding this comment.
这里直接拿 eip 的 subnet 的 gw， 不然当多公网时，这个数据就不对了。
zbb88888
reviewed
Jan 26, 2024
zhaocongqi
reviewed
Jan 26, 2024
pkg/controller/ovn_fip.go
Outdated
| @@ -457,6 +479,12 @@ func (c *Controller) handleDelOvnFip(key string) error { | |||
| } | |||
| // ovn delete fip nat | |||
| if cachedFip.Status.Vpc != "" && cachedFip.Status.V4Eip != "" && cachedFip.Status.V4Ip != "" { | |||
| if cachedFip.Status.Vpc == c.config.ClusterRouter { | |||
| match := fmt.Sprintf("ip4.src == %s", cachedFip.Status.V4Ip) | |||
There was a problem hiding this comment.
通过port group和address set同意管理需要出external network的pod的策略路由，不然每多一个fip pod就会多一条规则
Signed-off-by: HuangWei <[email protected]>
|
@a180285 please fix the go-lint issues |
|
@oilbeater 我看 #2090 最后给了手动解决的办法。这个 PR 还需要合并吗？ |
|
我先关掉吧，后面需要再打开 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #3502
WHAT
copilot:summary
copilot:poem
HOW
copilot:walkthrough