fix: should use domain-qualified finalizer name #3748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should migrate the finalizer field during initialization. |
ok， |
zhangzujian
reviewed
Feb 21, 2024
zbb88888
force-pushed
the
fix-finalizer
branch
from
9a8ffe0 to
c2949c1
Compare
zhangzujian
reviewed
Feb 21, 2024
zhangzujian
approved these changes
Feb 21, 2024
zbb88888
force-pushed
the
fix-finalizer
branch
from
fdf3f42 to
bb7a0aa
Compare
Signed-off-by: bobz965 <[email protected]>
Signed-off-by: bobz965 <[email protected]>
Signed-off-by: bobz965 <[email protected]>
Co-authored-by: 张祖建 <[email protected]>
Signed-off-by: bobz965 <[email protected]>
Signed-off-by: bobz965 <[email protected]>
zbb88888
force-pushed
the
fix-finalizer
branch
from
bb7a0aa to
45de792
Compare
zbb88888
added a commit
that referenced
this pull request
Feb 21, 2024
* fix: should use domain-qualified finalizer name --------- Signed-off-by: bobz965 <[email protected]> Co-authored-by: 张祖建 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #(issue-number)