Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple IPPools in the namespace #4777

Merged
merged 30 commits into from
Dec 30, 2024
Merged

Support multiple IPPools in the namespace #4777

merged 30 commits into from
Dec 30, 2024

Conversation

cnvergence
Copy link
Contributor

@cnvergence cnvergence commented Nov 28, 2024 •
edited
Loading

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

While reproducing issue #4687 (comment)
I have found that when user have multiple IPPools in the single namespace, pods without ippool annotation won’t be able to pick up a correct address.

Which issue(s) this PR fixes

Fixes #4687

@cnvergence cnvergence marked this pull request as ready for review December 4, 2024 17:58
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. feature New network feature test automation tests labels Dec 4, 2024
@coveralls
Copy link

coveralls commented Dec 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12545917939

Details

  • 0 of 30 (0.0%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 22.079%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/namespace.go 0 10 0.0%
pkg/controller/pod.go 0 20 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controller/namespace.go 1 0.0%
pkg/ovs/ovn-nb-bfd.go 2 61.61%
Totals Coverage Status
Change from base Build 12543190821: -0.01%
Covered Lines: 10160
Relevant Lines: 46016
💛 - Coveralls

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Dec 6, 2024
@zhangzujian zhangzujian linked an issue Dec 9, 2024 that may be closed by this pull request
[BUG] 集群中存在多个子网和 IP 池时，kubeovn 无法正确识别 attachnet.default.ovn.kubernetes.io/logical_switch: subnet-10-69 为 kubevirt VirtualMachine 分配 IP 地址 #4573
Closed
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Dec 11, 2024
@cnvergence cnvergence force-pushed the fix-ipampools-ns branch 5 times, most recently from a852962 to ded43bd Compare December 12, 2024 14:07
@cnvergence cnvergence mentioned this pull request Dec 12, 2024
Closed
@cnvergence
Copy link
Contributor Author

PTAL @zhangzujian

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Dec 16, 2024
@cnvergence
Copy link
Contributor Author

@zhangzujian thanks for the review, updated the PR

@dosubot dosubot bot removed the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 17, 2024
@cnvergence
e2e change to stateful set
4dd4f05 
Signed-off-by: Karol Szwaj <[email protected]>
@cnvergence
e2e update new test case
7c0c6b1 
Signed-off-by: Karol Szwaj <[email protected]>
@cnvergence
e2e fix the subnet name
0031afa 
Signed-off-by: Karol Szwaj <[email protected]>
@cnvergence
e2e remove list comparison
f6e7447 
Signed-off-by: Karol Szwaj <[email protected]>
@cnvergence
e2e cleanup resources
760ab23 
Signed-off-by: Karol Szwaj <[email protected]>
@cnvergence
e2e fix checking ippool usage
e2712c6 
Signed-off-by: Karol Szwaj <[email protected]>
@cnvergence
e2e update post-review
fa66f73 
Signed-off-by: Karol Szwaj <[email protected]>
@cnvergence
e2e reorder cleanup
7adf5ff 
Signed-off-by: Karol Szwaj <[email protected]>
@cnvergence
e2e reorder cleanup
60537d5 
Signed-off-by: Karol Szwaj <[email protected]>
@cnvergence
rename var
8f08ac7 
Signed-off-by: Karol Szwaj <[email protected]>
@cnvergence
drop defer func
4524c50 
Signed-off-by: Karol Szwaj <[email protected]>
@cnvergence
update the branch
db8c55d 
Signed-off-by: Karol Szwaj <[email protected]>
@cnvergence
add a new test case for multiple ippools
6dff69a 
Signed-off-by: Karol Szwaj <[email protected]>
@cnvergence
add a new test case for multiple ippools
f8a391b 
Signed-off-by: Karol Szwaj <[email protected]>
@cnvergence
add a new test case for multiple ippools
29bce98 
Signed-off-by: Karol Szwaj <[email protected]>
@cnvergence
check if there are available addresses before adding ippool from name…
bdbd303 
…space

Signed-off-by: Karol Szwaj <[email protected]>
@cnvergence
add cleanup to the Describe func
c31bf6b 
Signed-off-by: Karol Szwaj <[email protected]>
zhangzujian
zhangzujian reviewed Dec 30, 2024
View reviewed changes
pkg/controller/pod.go Outdated Show resolved Hide resolved
@cnvergence
go fumpt
464c30a 
Signed-off-by: Karol Szwaj <[email protected]>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 30, 2024
@zhangzujian zhangzujian merged commit 010b701 into kubeovn:master Dec 30, 2024
67 of 68 checks passed
@cnvergence cnvergence deleted the fix-ipampools-ns branch January 7, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangzujian zhangzujian zhangzujian approved these changes

Assignees
No one assigned
Labels
feature New network feature lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. test automation tests
Projects
None yet
Milestone
No milestone
3 participants
@cnvergence @coveralls @zhangzujian