auto detect kubevirt install #4791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clyi <[email protected]>
dosubot
bot
added
the
size:M
Pull Request Test Coverage Report for Build 12191235176Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
bobz965
approved these changes
Dec 4, 2024
Signed-off-by: clyi <[email protected]>
zhangzujian
reviewed
Dec 5, 2024
Signed-off-by: clyi <[email protected]>
zhangzujian
reviewed
Dec 5, 2024
zhangzujian
reviewed
Dec 5, 2024
Signed-off-by: clyi <[email protected]>
zhangzujian
reviewed
Dec 5, 2024
Signed-off-by: clyi <[email protected]>
zhangzujian
reviewed
Dec 5, 2024
zhangzujian
reviewed
Dec 5, 2024
Signed-off-by: clyi <[email protected]>
zhangzujian
approved these changes
Dec 6, 2024
changluyi
added a commit
that referenced
this pull request
Dec 27, 2024
* auto detect kubevirt install --------- Signed-off-by: clyi <[email protected]>
changluyi
added a commit
that referenced
this pull request
Dec 27, 2024
* auto detect kubevirt install --------- Signed-off-by: clyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
有可能kubevirt 比 kube-ovn 晚安装，这个迁移优化的功能就没有及时激活，不太好用，所以想加一个监听kubevirt CRD安装，一旦监听到就开启kubevirt相关informer
本来想做成能够在kubevirt 卸载后，kube-ovn自动关闭informerfactory，然后重新安装，再次启动。但
碰到了一些问题，informerFactory start了以后，通过给stopChan 发消息来关闭，执行shutdown。然后再start ，informer似乎就不会再去监听了。
所以这个PR 就暂时没有考虑 kubevirt 卸载的情况。
Which issue(s) this PR fixes
Fixes #(issue-number)