Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use JSON merge patch to update labels/annotations #4838

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Dec 17, 2024

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

Fixes #4229

@zhangzujian zhangzujian added bug Something isn't working need backport labels Dec 17, 2024
@zhangzujian zhangzujian force-pushed the fix-patch branch 2 times, most recently from 98b890a to 6a09637 Compare December 17, 2024 08:27
@coveralls
Copy link

coveralls commented Dec 17, 2024

Pull Request Test Coverage Report for Build 12373433471

Details

  • 16 of 165 (9.7%) changed or added relevant lines in 15 files are covered.
  • 6 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.02%) to 21.943%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/ovn_ic_controller/controller.go 0 1 0.0%
pkg/speaker/controller.go 0 1 0.0%
pkg/controller/endpoint.go 0 3 0.0%
pkg/util/patch.go 16 19 84.21%
pkg/controller/inspection.go 0 4 0.0%
pkg/ovn_ic_controller/ovn_ic_controller.go 0 4 0.0%
pkg/controller/external_gw.go 0 5 0.0%
pkg/controller/node.go 0 6 0.0%
pkg/controller/init.go 0 7 0.0%
pkg/controller/namespace.go 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controller/node.go 1 0.0%
pkg/controller/init.go 1 0.0%
pkg/ovn_leader_checker/ovn.go 2 0.0%
pkg/controller/pod.go 2 0.0%
Totals Coverage Status
Change from base Build 12368866861: 0.02%
Covered Lines: 10160
Relevant Lines: 46301

💛 - Coveralls

@zhangzujian zhangzujian marked this pull request as ready for review December 17, 2024 20:03
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. enhancement Improve exist functions labels Dec 17, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 18, 2024
@zhangzujian zhangzujian merged commit a88306a into kubeovn:master Dec 18, 2024
72 checks passed
@zhangzujian zhangzujian deleted the fix-patch branch December 18, 2024 05:55
zhangzujian added a commit that referenced this pull request Dec 18, 2024
zhangzujian added a commit that referenced this pull request Dec 18, 2024
zhangzujian added a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Improve exist functions lgtm This PR has been approved by a maintainer need backport size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Use JSON merge patch to update labels/annotations
3 participants