Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix getting subnet cidr by protocol #4844

Merged
merged 2 commits into from
Dec 18, 2024
Merged

fix getting subnet cidr by protocol #4844

merged 2 commits into from
Dec 18, 2024

Conversation

zhangzujian
Copy link
Member

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

Fixes #4843

@zhangzujian zhangzujian added bug Something isn't working need backport labels Dec 17, 2024
@coveralls
Copy link

coveralls commented Dec 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12387104291

Details

  • 4 of 14 (28.57%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 21.948%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/daemon/gateway.go 4 7 57.14%
pkg/daemon/gateway_linux.go 0 7 0.0%
Totals Coverage Status
Change from base Build 12384894311: 0.02%
Covered Lines: 10183
Relevant Lines: 46397
💛 - Coveralls

@zhangzujian zhangzujian marked this pull request as ready for review December 17, 2024 12:45
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 17, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 18, 2024
@oilbeater
Copy link
Collaborator

getCidrByProtocol needs a unit test.

@zhangzujian
add unittest
faa1382 
Signed-off-by: zhangzujian <[email protected]>
@zhangzujian zhangzujian merged commit 64acd01 into kubeovn:master Dec 18, 2024
15 checks passed
@zhangzujian zhangzujian deleted the fix-iptables-rule branch December 18, 2024 05:45
zhangzujian added a commit that referenced this pull request Dec 18, 2024
@zhangzujian
fix getting subnet cidr by protocol (#4844)
ae97639 
Signed-off-by: zhangzujian <[email protected]>
zhangzujian added a commit that referenced this pull request Dec 18, 2024
@zhangzujian
fix getting subnet cidr by protocol (#4844)
e19f48c 
Signed-off-by: zhangzujian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oilbeater oilbeater oilbeater approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer need backport size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] kube-ovn-cni adds ip6tables rules for an IPv4 subnet
3 participants
@zhangzujian @coveralls @oilbeater