Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gateway node check for centralized ecmp subnets #4847

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

zhangzujian
Copy link
Member

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

kube-ovn-controller gateway nodes by "privileged" raw ICMP ping. NET_RAW is required to do these checks.

@zhangzujian zhangzujian added need backport bug Something isn't working labels Dec 18, 2024
@coveralls
Copy link

coveralls commented Dec 18, 2024

Pull Request Test Coverage Report for Build 12387506867

Details

  • 0 of 22 (0.0%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.005%) to 22.127%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/controller.go 0 1 0.0%
pkg/controller/node.go 0 21 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controller/node.go 1 0.0%
pkg/ovs/ovn-nb-port_group.go 2 82.53%
Totals Coverage Status
Change from base Build 12387489966: -0.005%
Covered Lines: 10165
Relevant Lines: 45940

💛 - Coveralls

@zhangzujian zhangzujian marked this pull request as ready for review December 18, 2024 07:27
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 18, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 18, 2024
@zhangzujian zhangzujian merged commit 1caca2c into kubeovn:master Dec 18, 2024
67 of 68 checks passed
@zhangzujian zhangzujian deleted the fix-ping branch December 18, 2024 09:52
zhangzujian added a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer need backport size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants