Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: err is always nil #4857

Merged
merged 3 commits into from
Dec 20, 2024
Merged

fix: err is always nil #4857

merged 3 commits into from
Dec 20, 2024

Conversation

zcq98
Copy link
Member

@zcq98 zcq98 commented Dec 19, 2024

Pull Request

What type of this PR

Examples of user facing changes:

  • Bug fixes

Which issue(s) this PR fixes

If err is not nil, the previous code will return

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Dec 19, 2024
@zcq98
fix ut failed
086f596 
Signed-off-by: zcq98 <[email protected]>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12408542225

Details

  • 1 of 3 (33.33%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 22.126%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/gc.go 0 1 0.0%
pkg/daemon/handler.go 0 1 0.0%
Totals Coverage Status
Change from base Build 12405879506: 0.0%
Covered Lines: 10164
Relevant Lines: 45937
💛 - Coveralls

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 20, 2024
@oilbeater oilbeater merged commit 6478007 into kubeovn:master Dec 20, 2024
68 checks passed
@zcq98 zcq98 deleted the fix branch December 20, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobz965 bobz965 bobz965 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zcq98 @coveralls @bobz965 @oilbeater