Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: kube-ovn-controller cannot be ready when ENABLE_METRICS is false #4865

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: kube-ovn-controller cannot be ready when ENABLE_METRICS is false #4865

wants to merge 1 commit into from

Conversation

zcq98
Copy link
Member

@zcq98 zcq98 commented Dec 23, 2024

Pull Request

What type of this PR

Examples of user facing changes:

  • Bug fixes

Which issue(s) this PR fixes

Fixes #4862

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Dec 23, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12464002853

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 22.126%
Files with Coverage Reduction New Missed Lines %
pkg/ovs/ovn-nb-port_group.go 2 82.53%
Totals Coverage Status
Change from base Build 12434320848: 0.0%
Covered Lines: 10164
Relevant Lines: 45937
💛 - Coveralls

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 24, 2024
@zcq98
Copy link
Member Author

zcq98 commented Dec 24, 2024

@zhangzujian could you help review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobz965 bobz965 bobz965 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] kube-ovn-controller cannot be ready when ENABLE_METRICS is false
3 participants
@zcq98 @coveralls @bobz965